Updated developer docs to include Kind #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
reviewed
Apr 15, 2024
Pull Request Test Coverage Report for Build 8709304887Details
💛 - Coveralls |
tenzen-y
reviewed
Apr 16, 2024
|
@franciscojavierarceo Could you resolve DCO issues follow this guideline? |
Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
franciscojavierarceo
force-pushed
the
update-dev-docs
branch
from
075d895
to
2baaf63
Compare
|
@tenzen-y done |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: franciscojavierarceo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
* Updated developer docs to include Kind Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> --------- Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
* Updated developer docs to include Kind Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> * Update docs/development/developer_guide.md Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> --------- Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding Kind as an alternative in getting setup with local Kubernetes.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: