Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Dev Guide #417

Merged
merged 1 commit into from Feb 28, 2018
Merged

Dashboard: Dev Guide #417

merged 1 commit into from Feb 28, 2018

Conversation

wbuchwalter
Copy link
Contributor

@wbuchwalter wbuchwalter commented Feb 27, 2018

#411
Add a developer guide for the dashboard.

More doc is ultimately needed, but this is the most pressing part to unblock people from contributing.


This change is Reviewable

@k8s-ci-robot
Copy link

@wbuchwalter: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 2ccfafa link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coveralls
Copy link

coveralls commented Feb 27, 2018

Coverage Status

Coverage remained the same at 27.475% when pulling 2ccfafa on wbuchwalter:doc-dashboard into 0759f7a on kubeflow:master.

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jimexist
Copy link
Member

@wbuchwalter i can help adding sections about linting, etc. if needed.

@gaocegege
Copy link
Member

Merge it since it is about docs, then no need to be blocked by the CI.

@gaocegege gaocegege merged commit cf97cd5 into kubeflow:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants