E2E test for the CRD #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jlewi
commented
Oct 13, 2017
jlewi
commented
- Add links to the testgrid.
- Start expanding runner.py to run an actual E2E test.
* Start expanding runner.py to run an actual E2E test.
…s/master/test/helm-test/main.go. This will serve as the basis for deploying and running the tests.
* Deploys the TfJob helm chart and then runs the tests. * Doesn't deploy the chart in its own namespace because the E2E test assumes its using default namespace.
* The output can be used by runner.py to determine the GCR path of the newly built image.
and run the tests on. * Fix a lint issue in the helm chart.
* Need to install docker so we can build the image locally without GCB. * Fix some flags. * runner.py should delete the GKE cluster. * Add instructions about running the test inside a Docker container.
|
good to see the presubmit is actually running now, but github status is not showing up properly |
|
/test all |
|
It looks like "/test all" successfully triggers jobs. The comment above appears to have triggered the run So I think the only problem with GitHub integration is the k8s robots can't update the conversation thread. |
|
/test all |
* Need to get credentials otherwise helm won't work. * Echo command output to logs so that it will show up in job log. * Add some notes on the steps followed to setup Prow integration.
* Run helm init as part of retry loop waiting for helm to be initialized. * Set a 2 minute timeout on waiting for helm to be initialized.
|
/test all |
up running in namespace test-pods.
* Need to upgrade six to support google.cloud.storage library
|
/test all |
Tests should pull runner.py from the repository and not the image.
|
/test all |
so we know which image a job ran in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.