Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to test Prow presubmit integration. #50

Merged
merged 5 commits into from
Oct 18, 2017
Merged

PR to test Prow presubmit integration. #50

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e47bcd
* Add links to the testgrid.
jlewi Oct 13, 2017
82a3e39
Revert changes to runner.
jlewi Oct 13, 2017
b3b9cd0
Add link to Prow jobs dashboard.
jlewi Oct 13, 2017
2a10d57
Merge branch 'master' into test_links
jlewi Oct 18, 2017
b1be6cd
Add notes about the bot account.
jlewi Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test-infra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ Below is some notes on what it took to integrate with K8s Prow instance.
* Add test dashboards to [testgrid/config/config.yaml](https://github.com/kubernetes/test-infra/pull/4951/files#diff-49f154cd90facc43fda49a99885e6d17)
* Modify [testgrid/jenkins_verify/jenkins_validat.go](https://github.com/kubernetes/test-infra/pull/4951/files#diff-7fb4731a02dd681bbd0daada8dd2f908)
to allow presubmits for the new repo.

1. For mlkube.io configure webhooks by following these [instructions](https://github.com/kubernetes/test-infra/blob/master/prow/getting_started.md#add-the-webhook-to-github)

* Use https://prow.k8s.io/hook as the target
* Get HMAC token from k8s test team

1. Add the k8s bot account, k8s-ci-robot, as an admin on the repository
* Admin privileges are needed to update status (but not comment)
* Someone with access to the bot will need to accept the request.
1. TODO(jlewi): Follow [instructions](https://github.com/kubernetes/test-infra/tree/master/gubernator#adding-a-repository-to-the-pr-dashboard) for adding a repository to the PR
dashboard.