Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate API reference docs #366

Closed
jlewi opened this issue Dec 18, 2018 · 7 comments
Closed

Generate API reference docs #366

jlewi opened this issue Dec 18, 2018 · 7 comments
Labels
Projects

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 18, 2018

We should generate API reference docs for various aspects of Kubeflow; e.g our custom operators, the Katib API, Pipelines API.

Here are instructions for how Kubernetes generates its reference docs. Looks like its based on OpenAPI specs.
https://kubernetes.io/docs/contribute/generate-ref-docs/kubernetes-api/

Related issues:
kubeflow/katib#120 - Document Katib API
kubeflow/training-operator#731 - Document TFJob API

@jlewi jlewi added area/0.4.0 area/docs help wanted Extra attention is needed labels Dec 18, 2018
@jlewi jlewi added this to New in 0.5.0 via automation Dec 18, 2018
@sarahmaddox
Copy link
Contributor

Here's the existing issue for the Pipelines reference: #345 - it includes some discussion.

@sarahmaddox
Copy link
Contributor

We need to think about how we'll include the generated reference docs in our Kubeflow website.
As an example, see Kubernetes:

@jlewi jlewi moved this from New to Fit & Finish in 0.5.0 Jan 6, 2019
@jlewi jlewi moved this from Fit & Finish to TFJob/PyTorch 1.0 in 0.5.0 Jan 6, 2019
@sarahmaddox
Copy link
Contributor

There's a REST API that you can use to, for example, create a new pipeline. Here is the swagger definition for the API:
https://github.com/kubeflow/pipelines/tree/master/backend/api/swagger

The Python SDK supports submitting pipeline runs programmatically:
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/_client.py

@sarahmaddox
Copy link
Contributor

Useful discussion happening over here: kubeflow/training-operator#731

@richardsliu richardsliu moved this from TFJob/PyTorch 1.0 to Fit & Finish in 0.5.0 Mar 4, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Mar 10, 2019

Docs for TFJob are now generated; kubeflow/training-operator#731 is closed.

@sarahmaddox Is there more work to be done here or can we close this issue?

@sarahmaddox
Copy link
Contributor

I'm not sure - are there any other APIs / CRDs we should generate references for? If so, perhaps we should create individual issues for those, and close this generic issue.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 26, 2019

SGTM. Lets close this issue and open up additional specific issues as needed.

@jlewi jlewi closed this as completed Mar 26, 2019
0.5.0 automation moved this from Fit & Finish to Done Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.5.0
  
Done
Development

No branches or pull requests

2 participants