Add support for PodDisruptionBudgets #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ricoberger
commented
Jun 28, 2020
ricoberger
commented
- Add support for PodDisruptionBudgets. The PDBs are available via the Config and Storage section.
- Fix a bug, where the light mode wasn't used, when the dark mode was the default.
It was not explicit checked if the darkMode settings exists or it was false. Therefor the disabled dark mode wasn't used on a system where the dark mode was enabled by default. Now it is checked if the darkMode property exists in the settings and only if it doesn't exists the default value will be used.
The config and storage section contains a new entry for PodDisruptionBudgets. The status of a PDB is dependens on the number of expected Pods and the current/desired healthiness Pods. If the number of expected Pods is 0, the status will be warning, because this means the PDB selector doesn't match any Pods. If the current number of healthy Pods is lower then the number of desired healthy Pods the status will be danger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.