Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling in terminal #138

Merged
merged 2 commits into from Jul 26, 2020
Merged

Fix scrolling in terminal #138

merged 2 commits into from Jul 26, 2020

Conversation

ricoberger
Copy link
Member

  • Remove the bouncing when a user scrolls in the terminal on iOS.
  • When the range selector is visible the height of the terminal was calculated wrong. It used the same value as for the search, but the range component is 2px higher.

@ricoberger
Fix scrolling in the terminal on iOS
9a4f181 
Remove the bouncing when a user scrolls in the terminal on iOS.
@ricoberger
Fix terminal height when select is visible
5118e5f 
When the range selector is visible the height of the terminal was
calculated wrong. It used the same value as for the search, but the
range component is 2px higher.
@ricoberger ricoberger added the bug Something isn't working label Jul 26, 2020
@ricoberger ricoberger merged commit 8e03da7 into master Jul 26, 2020
@ricoberger ricoberger deleted the fix-scrolling-in-terminal branch July 26, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ricoberger