Improve log handling #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default only the last 1000 log lines are loaded, because the complete log results in very high traffic. This could be problematic on mobile. The complete log can be loaded via a new menu button in the logs view. It's now possible to load the previous log of a container. This should improve the debugging capabilities of kubenav. Like for the current log there are two options: Load the last 1000 log lines or load the complete log. To refresh the log, the corresponding menu item must be pressed again. The refresh button is gone in favour for options menu.
The button property was added to the menu items in the namespace and log popover to identicat that they can be clicked on desktop. The space from the bottom of the view for the scroll down button was doubled, for easier handling on mobile.
To access the logs on desktop a button was added to the container items. Now it's not necessary anymore to swipe on the container name to access the logs on desktop. We had to add e.stopPropagation() to every button which can be accessed in the logs view, to avoid some side effects with the containers modal. The modal was opened without this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log handling was improved and instead of the refresh button it's now possible to select from multiple options for the logs:
By clicking on one of the provided items again, the logs will be refreshed.
The access to the logs on desktop was improved by adding a button to the container item.
Closes #11