Increase width of modals for larger sized screens #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
requested changes
Feb 18, 2020
There was a problem hiding this comment.
Hi @armandvanderwalt thank you for the PR. This is a great idea and very helpful especially for the logs view.
I added two suggestions, would be great if you can look through them.
|
@ricoberger I have made the requested changes, please feel free to have a look |
|
Thank you very much. 🙂 Note: Seems like the authentication against the GitHub Package Registry does not work in the GitHub Action... |
ricoberger
added a commit
that referenced
this pull request
Mar 4, 2020
Show the resources and the current usage for each pod in the list view. Show resource, usage, status, restarts and ready status for each container on the pods detail page. Since the container modal has a width of 90% on larger screen, we show some of the cards next to each other. The modal width and height was changed in PR #22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some CSS to increase the width of modals for larger sized displays to show more content in the modal