Improve default metrics #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of container_memory_usage_bytes we are now using container_memory_usage_bytes for the memory metrics now. The advatange of this that the graphs will be consistent with the metrics retrieved by the metrics API. For the node and cluster metrics we are also switching to this metric. So that the results for the graphs are the same as reported by kubectl top nodes. We also have adjusted the metrics for CPU usage and the Network I/O.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
container_memory_usage_byteswe are now usingcontainer_memory_usage_bytesfor the memory metrics now. The advantage of this that the graphs will be consistent with the metrics retrieved by the metrics API.For the node and cluster metrics we are also switching to this metric. So that the results for the graphs are the same as reported by
kubectl top nodes.We also have adjusted the metrics for CPU usage and the Network I/O.