Restructuring I #34
Merged
Restructuring I #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting the utils file into multiple files: - api: Contains all methods for API requests. This includes requests against the AWS and Google API and requests against the Kubernetes API server. - constants: Contains now also the keys for items whiche are saved into the localStorage. - storage: Contains all operations whiche are executed against localStorage. - helpers: Contains all other helper functions.
Instead of get and set we are using read and save for the functions for localStorage, because some of the function names are also used for API functions.
Add more comments to the context component and enable the tslint rule for max line length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the restructuring:
utilsfile into multiple files. Adding a central place for API calls and localStorage operations.max-line-lengthand set the maximum length of a line to 120 characters.