Appearance Customization (Dark Mode + Editor Theme) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ricoberger
commented
Mar 5, 2020
ricoberger
commented
- Manually hide the Splash Screen for faster startup time.
- Add option to customize the editor theme. The editor is used to edit yaml files and to show logs.
- Add dark mode 馃帀
Instead of waiting the default three seconds until the Splash Screen is hide, we are now hide the screen manually in the Context Provider for faster start up time.
Introduce a new menu item 'General' where a user can customize the appearance of kubenav. Currently it is possible to toggle the dark mode and to customize the editor theme.
We only use the IonAvatar component to show the hexagon. Each hexagon contains a white border wich is cutted in the dark mode. To avoid this we remove the default border radius.
The media query is needed for automatic dark mode detection. To support older devices the media query was removed. See: https://ionicframework.com/docs/theming/dark-mode#css-class-fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.