Rework Storage #430
Merged
Rework Storage #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using the Flutter Secure Storage package only on iOS and Android. On macOS, Linux and Windows we are using now the shared preferences package to store the users settings and bookmarks. To only use the Flutter Secure Storage package on iOS and Android we are using a fork of the package where we removed the other implementations: https://github.com/kubenav/flutter_secure_storage/tree/kubenav We decided to not use the package for desktop, because it was not working correctly for macOS, because the required provisioning profile for the Keychain Sharing capability could not be added in the GitHub Action :-(. If someone nows how we can build the app with the correct provisioning profile via our GitHub Action we can switch back to the Flutter Secure Storage package on desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using the Flutter Secure Storage package only on iOS and Android. On macOS, Linux and Windows we are using now the shared preferences package to store the users settings and bookmarks.
To only use the Flutter Secure Storage package on iOS and Android we are using a fork of the package where we removed the other implementations: https://github.com/kubenav/flutter_secure_storage/tree/kubenav
We decided to not use the package for desktop, because it was not working correctly for macOS, because the required provisioning profile for the Keychain Sharing capability could not be added in the GitHub Action :-(.
If someone nows how we can build the app with the correct provisioning profile via our GitHub Action we can switch back to the Flutter Secure Storage package on desktop.