Improve Cursor Style and Other Fixes #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
improve-cursor-style-and-other-fixes
branch
2 times, most recently
from
a4c5326
to
58c6a6b
Compare
On some items the cursor style wasn't adjusted on dekstop, so that there was no indication that the item is clickable. We also had the problem that the clickable area was to large for some items (e.g app actions). These issues should be fixed now. We also removed the dismiss option from the snackbar, because sometimes this could break the app, when the context isn't available anymore. In some places we still had used "Theme.of", which is now replaced with our new theme() function.
ricoberger
force-pushed
the
improve-cursor-style-and-other-fixes
branch
from
58c6a6b
to
fcbcfed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some items the cursor style wasn't adjusted on dekstop, so that there was no indication that the item is clickable. We also had the problem that the clickable area was to large for some items (e.g app actions). These issues should be fixed now.
We also removed the dismiss option from the snackbar, because sometimes this could break the app, when the context isn't available anymore.
In some places we still had used "Theme.of", which is now replaced with our new theme() function.