Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logs modal for valid json #44

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix logs modal for valid json #44

merged 1 commit into from
Mar 5, 2020

Commits on Mar 5, 2020

  1. Fix logs modal for valid json 

    If the returned logs from the Kubernetes API server are a valid JSON
object we are parsing the log and returning an object instead of a
string.

This had break the modal and the app crashes. This is now fixed, by
checking if the returned data is a string. If not we are reverting the
parsing befor passing the data to the Editor component.
    @ricoberger
    ricoberger committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f55b78d View commit details
    Browse the repository at this point in the history