Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several Problems with Provider Configuration #442

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

ricoberger
Copy link
Member

This commit contains several small fixes with the configuration of the cluster providers, the added fixes are listed below:

  • Use global list for AWS regions: Until now the supported AWS regions where maintained in across several widgets. Now we are using a globally available variable "awsRegions" to maintain them, so that we only have to add new regions at one place.
  • The json parsing of the providers when they were read from disk contained a bug, so that the providers doesn't contain the provider type after they were read. This is now fixed, so that the provider type is also available after the providers were read from our storage.
  • The created clusters for the AWS and Google provider didn't contain the "default" namespace, so that automatically all namespaces where selected. This is now changed, so that the "default" namespace is used like for the other providers.
  • The AWS SSO handling was improved, by disabling the buttons which can not be used until a required action was executed. This should help users to perform all actions in the correct order.
  • The refresh token handling for the Google provider was fixed. Until now it was only possible to use the OAuth client one time, because the seconde time the provider was used the response from Google didn't contain a refresh token, so that we were not able to use the provider. To fix this issue we had to add the "prompt=consent" parameter to the login url.

This commit contains several small fixes with the configuration of the
cluster providers, the added fixes are listed below:

- Use global list for AWS regions: Until now the supported AWS regions
  where maintained in across several widgets. Now we are using a
  globally available variable "awsRegions" to maintain them, so that we
  only have to add new regions at one place.
- The json parsing of the providers when they were read from disk
  contained a bug, so that the providers doesn't contain the provider
  type after they were read. This is now fixed, so that the provider
  type is also available after the providers were read from our storage.
- The created clusters for the AWS and Google provider didn't contain
  the "default" namespace, so that automatically all namespaces where
  selected. This is now changed, so that the "default" namespace is used
  like for the other providers.
- The AWS SSO handling was improved, by disabling the buttons which can
  not be used until a required action was executed. This should help
  users to perform all actions in the correct order.
- The refresh token handling for the Google provider was fixed. Until
  now it was only possible to use the OAuth client one time, because the
  seconde time the provider was used the response from Google didn't
  contain a refresh token, so that we were not able to use the provider.
  To fix this issue we had to add the "prompt=consent" parameter to the
  login url.
@ricoberger ricoberger merged commit 9b7cb17 into main Jan 13, 2023
@ricoberger ricoberger deleted the fix-several-problems-with-provider-configuration branch January 13, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant