Fix Theming of Icons #449
Merged
Fix Theming of Icons #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some icons were still using a static color instead of a color from our theme. The color of the icons which were using "Colors.grey[300]" are now using the primary or secondary text color of the selected theme. The icons are using the primary text color when the text uses the primary color. If the text uses the primary and secondary color the icons will use the secondary color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some icons were still using a static color instead of a color from our theme. The color of the icons which were using "Colors.grey[300]" are now using the primary or secondary text color of the selected theme.
The icons are using the primary text color when the text uses the primary color. If the text uses the primary and secondary color the icons will use the secondary color.