Improve Continuous Delivery GHA for macOS #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
improve-ci-gha-for-prs
branch
2 times, most recently
from
7e1f522
to
c5178fb
Compare
The continuous delivery GitHub Action requires some secrets for the macOS build, so that the action fails for PRs from external contributors. This PR adds a check to all steps, which require some secrets to omit them for PRs where the secrets are not present, so that the action will be green.
ricoberger
force-pushed
the
improve-ci-gha-for-prs
branch
from
c5178fb
to
2306877
Compare
ricoberger
added a commit
that referenced
this pull request
Jan 29, 2023
The change introduced in #483, caused a problem with the continuouse delivery action when a new release is published, because the signing steps are not executed. This should be fixed by running the necessary steps when: - The event name which triggers the action is "release" - The PR is created from a branch within the repository
ricoberger
added a commit
that referenced
this pull request
Jan 29, 2023
The change introduced in #483, caused a problem with the continuouse delivery action when a new release is published, because the signing steps are not executed. This should be fixed by running the necessary steps when: - The event name which triggers the action is "release" - The PR is created from a branch within the repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuous delivery GitHub Action requires some secrets for the macOS build, so that the action fails for PRs from external contributors. This PR adds a check to all steps, which require some secrets to omit them for PRs where the secrets are not present, so that the action will be green.