Allow Custom Redirect URL for OIDC and Google #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to specify a custom redirect url for the OIDC and Google provider. Since we only have to get the "code" parameter to finish the authentication flow, it doesn't matter if the site is hosted at kubenav.io or a user hosts them by themself. For the user it has not to allow kubenav.io as redirect url. The following html files can be hosted at the provided redirect url to make it easier to copy the token: - https://github.com/kubenav/kubenav/blob/main/kubenav.io/auth/oidc.html - https://github.com/kubenav/kubenav/blob/main/kubenav.io/auth/google.html
ricoberger
deleted the
allow-custom-redirect-url-for-oidc-and-google-provder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to specify a custom redirect url for the OIDC and Google provider. Since we only have to get the "code" parameter to finish the authentication flow, it doesn't matter if the site is hosted at kubenav.io or a user hosts them by themself. For the user it has not to allow kubenav.io as redirect url.
The following html files can be hosted at the provided redirect url to make it easier to copy the token: