Fix "Classic Mode" when User doesn't have any Clusters #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user doesn't have any clusters configured and selects one of the resources from the sidebar in the "classic mode" the app crashes. This was caused, since we assumed that a user must have an active cluster when visiting the page, which is only true for the default layout but not for the "classic mode". This is now fixed by adding conditional checks where required in the resources list widget and by throwing an error before making an API request when the list of clusters is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user doesn't have any clusters configured and selects one of the resources from the sidebar in the "classic mode" the app crashes. This was caused, since we assumed that a user must have an active cluster when visiting the page, which is only true for the default layout but not for the "classic mode".
This is now fixed by adding conditional checks where required in the resources list widget and by throwing an error before making an API request when the list of clusters is empty.
Fixes #524