Improve Charts #651
Merged
Improve Charts #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains several improvements to the charts used within the app: - The charts used for `ResourceQuotas` and `LimitRanges` are now splitted, so that different metrics are not mixed anymore - Charts which are related to CPU cores are now using `m` instead of `Cores` as unit. - The live metrics charts are now containing a tooltip. - The legend in the live metrics charts are now better formatted, so that the text doesn't overflow anymore, when the name of a container is very long. - The x axis in the Prometheus charts is now better formatted, so that the overlap of labels is minimized. - The values in the Prometheus charts are now better formatted by using the `NumberFormat.compact(locale: "en_US").format()` function. - In the Prometheus charts it is now possible to select a single metric in the legend, which should be shown in the chart. We also added a new `decoration` parameter to all text styling functions, so that a text can be underlined, which is used to indicate the selected metric in the Prometheus charts legend.
ricoberger
force-pushed
the
improve-charts
branch
from
fb052eb
to
a093dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains several improvements to the charts used within the app:
ResourceQuotasandLimitRangesare now splitted, so that different metrics are not mixed anymoreminstead ofCoresas unit.NumberFormat.compact(locale: "en_US").format()function.We also added a new
decorationparameter to all text styling functions, so that a text can be underlined, which is used to indicate the selected metric in the Prometheus charts legend.