Improve terminal handling #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ricoberger
commented
May 24, 2020
•
ricoberger
commented
- Send resize message for the shell to the backend.
- Close the SSE connection on an error.
- Increase timeout for streaming logs to 6h.
- Use xterm Terminal instead of the Ace Editor to show logs.
- Disable stdin for terminal when logs are shown.
- Do not focus terminal for logs, because this will open the keyboard on mobile.
- Resize the terminal when the keyboard is toggled.
- Send resize message for the shell to the backend. - Close the SSE connection on an error. - Increase timeout for streaming logs to 6h.
Instead of showing logs in the editor we are now showing logs also in the Terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.