Improve rendering #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize rerendering of components by using React.memo. Some renderings which were caused by React Router are unnecessary. By using React.meno these rerenderings are avoided. Introduce useAsyncFn to improve the data fetching in the components. This needs some more refactoring in components which were not touched. The introduction of useAsyncFn fixes also a bug where the wrong page was displayed. This could happen when the page was changed before the API call was finished.
Use a status function instead of a status variable to determine the status of a resource. Distinguish between warning and danger. The status should be danger, when required status indicator is zero or undefined. When this isn't the case and the success probe failes the status is set to warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useAsyncFnto improve the data fetching in the components.warninganddangerstatus. If thesuccesscheck fails, the status is set todanger, when a required value is undefined or zero. For everything else the status is set towarning. Closes Improvement: Show Deployments yellow if... #81.