Fix (Cluster) Role Bindings #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the singular and plural for Endpoints. - Fix check for the Storage Class provisioner. - Change sequence of ports shown for a Service.
si458
reviewed
Jun 10, 2020
| {port.protocol ? `/${port.protocol}` : ''} | ||
| {port.targetPort ? ` > ${port.targetPort}` : ''} | ||
| {port.nodePort ? ` ${port.targetPort ? ` ${port.nodePort}` : ` > ${port.nodePort}`}` : ''} |
There was a problem hiding this comment.
this seems to have broken the display now?
it now shows NAME 9000/TCP > 9000 32540
which makes no sense?
maybe it could display NAME 9000/TCP > 32540/TCP
There was a problem hiding this comment.
Ah shit, you are right this shouldn't go to master...
There was a problem hiding this comment.
Reverted this in the master branch. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item.roleRef.namefield does exists (closes cluster role bindings generates blank white page #95).