Scaling functionality of Kubernetes cluster via kn-scale #384
Conversation
andersla
changed the title
|
Toppen! Looking forward to review this 🙂 |
|
Now merged with master |
|
@andersla there seem to be still stuff from the azure alternate image https://github.com/kubenow/KubeNow/pull/384/files#diff-3e8d33261969253d9b1be70860e330d4R4 |
|
Its because I forgot to push it:-) |
mcapuccini
changed the title
There was a problem hiding this comment.
LGTM code-wise.
@carmat88 I added you as reviewer as well. Could test this according to kubenow/docs#36? Then if everything looks good to you please merge, both this and the docs PR.
|
@mcapuccini The test in travis seems to be fine. However as per discussion with @andersla, it will probably nice to have again another test once the kn-scale command is completed. I'm about to submit the extra line in |
carmat88
force-pushed
the
feature/kn-scale
branch
from
03d57f5
to
63b39d0
Compare
carmat88
force-pushed
the
feature/kn-scale
branch
from
63b39d0
to
fc6f5b8
Compare
|
Alright, looks all good to me. Please let me know if you have any comments, otherwise tomorrow I will proceed with merging this and kubenow/docs#36. Cheers! |
|
Sure! Please go ahead 🙂 |
Change content and motivation
Adds manual scaling functionality of Kubernetes cluster via command kn-scale