perf: use empty struct to reduce memory usage (#2327)

kubeovn · Feb 11, 2023 · 0bd7c7e · 0bd7c7e
1 parent b2eaea0
commit 0bd7c7e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/controller/pod.go b/pkg/controller/pod.go
@@ -65,7 +65,7 @@ func (n *NamedPort) AddNamedPortByPod(pod *v1.Pod) {
 			if _, ok := n.namedPortMap[ns]; ok {
 				if _, ok := n.namedPortMap[ns][port.Name]; ok {
 					if n.namedPortMap[ns][port.Name].PortId == port.ContainerPort {
-						n.namedPortMap[ns][port.Name].Pods[podName] = ""
+						n.namedPortMap[ns][port.Name].Pods[podName] = struct{}{}
 					} else {
 						klog.Errorf("named port %s has already be defined with portID %d",
 							port.Name, n.namedPortMap[ns][port.Name].PortId)
@@ -77,7 +77,7 @@ func (n *NamedPort) AddNamedPortByPod(pod *v1.Pod) {
 			}
 			n.namedPortMap[ns][port.Name] = &util.NamedPortInfo{
 				PortId: port.ContainerPort,
-				Pods:   map[string]string{podName: ""},
+				Pods:   map[string]struct{}{podName: {}},
 			}
 		}
 	}

diff --git a/pkg/util/named_port.go b/pkg/util/named_port.go
@@ -2,5 +2,5 @@ package util
 
 type NamedPortInfo struct {
 	PortId int32
-	Pods   map[string]string // pods named port belong to
+	Pods   map[string]struct{}
 }