Skip to content

Commit

Permalink
fix: no need to set address for ls to lr port
Browse files Browse the repository at this point in the history
The address type has already be set to router, set mac address will bring back performance penalty
  • Loading branch information
oilbeater committed Nov 30, 2021
1 parent ba1f552 commit 28a9392
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/ovs/ovn-nbctl.go
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,6 @@ func (c Client) createRouterPort(ls, lr, ip, mac string) error {
_, err := c.ovnNbCommand(MayExist, "lsp-add", ls, lsTolr, "--",
"set", "logical_switch_port", lsTolr, "type=router", "--",
"lsp-set-addresses", lsTolr, "router", "--",
"set", "logical_switch_port", lsTolr, fmt.Sprintf("addresses=\"%s\"", mac), "--",
"set", "logical_switch_port", lsTolr, fmt.Sprintf("options:router-port=%s", lrTols), "--",
"set", "logical_switch_port", lsTolr, fmt.Sprintf("external_ids:vendor=%s", util.CniTypeName))
if err != nil {
Expand Down

0 comments on commit 28a9392

Please sign in to comment.