Skip to content

Commit

Permalink
append vm deletion check (#1390)
Browse files Browse the repository at this point in the history
  • Loading branch information
hongzhen-ma committed Mar 21, 2022
1 parent 0d663eb commit 677690d
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions pkg/controller/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func (c *Controller) enqueueDeletePod(obj interface{}) {
c.deletePodQueue.Add(obj)
}

if delete, err := appendCheckStatefulSetPodToDel(c, p); delete && err == nil {
if delete, err := appendCheckPodToDel(c, p); delete && err == nil {
klog.V(3).Infof("enqueue delete pod %s", key)
c.deletePodQueue.Add(obj)
}
Expand All @@ -161,6 +161,10 @@ func (c *Controller) enqueueDeletePod(obj interface{}) {
klog.V(3).Infof("enqueue delete pod %s", key)
c.deletePodQueue.Add(obj)
}
if delete, err := appendCheckPodToDel(c, p); delete && err == nil {
klog.V(3).Infof("enqueue delete pod %s", key)
c.deletePodQueue.Add(obj)
}
} else {
klog.V(3).Infof("enqueue delete pod %s", key)
c.deletePodQueue.Add(obj)
Expand Down Expand Up @@ -636,7 +640,7 @@ func (c *Controller) handleDeletePod(pod *v1.Pod) error {

var keepIpCR bool
if ok, sts := isStatefulSetPod(pod); ok {
delete, err := appendCheckStatefulSetPodToDel(c, pod)
delete, err := appendCheckPodToDel(c, pod)
keepIpCR = !isStatefulSetPodToDel(c.config.KubeClient, pod, sts) && !delete && err == nil
}

Expand Down Expand Up @@ -1344,7 +1348,7 @@ func (c *Controller) deleteAttachmentNetWorkIP(pod *v1.Pod) error {
return nil
}

func appendCheckStatefulSetPodToDel(c *Controller, pod *v1.Pod) (bool, error) {
func appendCheckPodToDel(c *Controller, pod *v1.Pod) (bool, error) {
// subnet for ns has been changed, and statefulset pod's ip is not in the range of subnet's cidr anymore
podNs, err := c.namespacesLister.Get(pod.Namespace)
if err != nil {
Expand Down

0 comments on commit 677690d

Please sign in to comment.