fix: gc lb

pkg/controller/gc.go

@@ -274,7 +274,10 @@ func (c *Controller) gcLoadBalancer() error {
 		for _, vpc := range vpcs {
 			for _, subnetName := range vpc.Status.Subnets {
 				_, err := c.subnetsLister.Get(subnetName)
-				if err != nil && !k8serrors.IsNotFound(err) {
+				if err != nil {
+					if k8serrors.IsNotFound(err) {
+						continue
+					}
 					return err
 				}
 				err = c.ovnClient.RemoveLbFromLogicalSwitch(

pkg/controller/vpc.go

@@ -575,7 +575,13 @@ func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaul
 	}
 
 	for _, subnet := range allSubnets {
-		if subnet.Spec.Vpc == vpc.Name {
+		deleted, err := c.handleSubnetFinalizer(subnet)
+		if err != nil {
+			klog.Errorf("handle subnet finalizer failed %v", err)
+			return nil, "", err
+		}
+
+		if !deleted && subnet.Spec.Vpc == vpc.Name {
 			subnets = append(subnets, subnet.Name)
 			if subnet.Spec.Default {
 				defaultSubnet = subnet.Name

pkg/ovs/ovn-nbctl.go

@@ -328,22 +328,22 @@ func (c Client) AddLbToLogicalSwitch(tcpLb, tcpSessLb, udpLb, udpSessLb, ls stri
 
 func (c Client) RemoveLbFromLogicalSwitch(tcpLb, tcpSessLb, udpLb, udpSessLb, ls string) error {
 	if err := c.removeLoadBalancerFromLogicalSwitch(tcpLb, ls); err != nil {
-		klog.Errorf("failed to add tcp lb to %s, %v", ls, err)
+		klog.Errorf("failed to remove tcp lb from %s, %v", ls, err)
 		return err
 	}
 
 	if err := c.removeLoadBalancerFromLogicalSwitch(udpLb, ls); err != nil {
-		klog.Errorf("failed to add udp lb to %s, %v", ls, err)
+		klog.Errorf("failed to remove udp lb from %s, %v", ls, err)
 		return err
 	}
 
 	if err := c.removeLoadBalancerFromLogicalSwitch(tcpSessLb, ls); err != nil {
-		klog.Errorf("failed to add tcp session lb to %s, %v", ls, err)
+		klog.Errorf("failed to remove tcp session lb from %s, %v", ls, err)
 		return err
 	}
 
 	if err := c.removeLoadBalancerFromLogicalSwitch(udpSessLb, ls); err != nil {
-		klog.Errorf("failed to add udp session lb to %s, %v", ls, err)
+		klog.Errorf("failed to remove udp session lb from %s, %v", ls, err)
 		return err
 	}