Resolve SetLoadBalancerAffinityTimeout not being effective

pkg/ovs/ovn-nb-load_balancer.go

@@ -138,6 +138,7 @@ func (c *ovnClient) SetLoadBalancerAffinityTimeout(lbName string, timeout int) e
 		options[k] = v
 	}
 	options["affinity_timeout"] = value
+	lb.Options = options
 	if err := c.UpdateLoadBalancer(lb, &lb.Options); err != nil {
 		return fmt.Errorf("failed to set affinity timeout of lb %s to %d: %v", lbName, timeout, err)
 	}

pkg/ovs/ovn-nb-load_balancer_test.go

@@ -2,6 +2,7 @@ package ovs
 
 import (
 	"fmt"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -370,3 +371,44 @@ func (suite *OvnClientTestSuite) testDeleteLoadBalancerOp() {
 		require.Len(t, ops, 0)
 	})
 }
+
+func (suite *OvnClientTestSuite) testSetLoadBalancerAffinityTimeout() {
+	t := suite.T()
+	t.Parallel()
+
+	ovnClient := suite.ovnClient
+	lbName := "test-set-lb-affinity-timeout"
+
+	err := ovnClient.CreateLoadBalancer(lbName, "tcp", "")
+	require.NoError(t, err)
+
+	lb, err := ovnClient.GetLoadBalancer(lbName, false)
+	require.NoError(t, err)
+
+	oldOptions := make(map[string]string, 1)
+	oldOptions["stateless"] = "true"
+	lb.Options = oldOptions
+	err = ovnClient.UpdateLoadBalancer(lb, &lb.Options)
+	require.NoError(t, err)
+
+	expectedTimeout := 30
+	t.Run("add new affinity timeout to load balancer options", func(t *testing.T) {
+		err := ovnClient.SetLoadBalancerAffinityTimeout(lbName, expectedTimeout)
+		require.NoError(t, err)
+
+		lb, err := ovnClient.GetLoadBalancer(lbName, false)
+		require.NoError(t, err)
+
+		require.Equal(t, lb.Options["affinity_timeout"], strconv.Itoa(expectedTimeout))
+	})
+
+	t.Run("add new affinityTimeout to load balancer options repeatedly", func(t *testing.T) {
+		err := ovnClient.SetLoadBalancerAffinityTimeout(lbName, expectedTimeout)
+		require.NoError(t, err)
+
+		lb, err := ovnClient.GetLoadBalancer(lbName, false)
+		require.NoError(t, err)
+
+		require.Equal(t, lb.Options["affinity_timeout"], strconv.Itoa(expectedTimeout))
+	})
+}

pkg/ovs/ovn-nb-suite_test.go

@@ -330,6 +330,10 @@ func (suite *OvnClientTestSuite) Test_DeleteLoadBalancerOp() {
 	suite.testDeleteLoadBalancerOp()
 }
 
+func (suite *OvnClientTestSuite) Test_SetLoadBalancerAffinityTimeout() {
+	suite.testSetLoadBalancerAffinityTimeout()
+}
+
 /* port_group unit test */
 func (suite *OvnClientTestSuite) Test_CreatePortGroup() {
 	suite.testCreatePortGroup()