abort kube-ovn-controller on leader change (#1797)

pkg/controller/election.go

@@ -24,6 +24,7 @@ type leaderElectionConfig struct {
 	Client clientset.Interface
 
 	ElectionID string
+	WasLeader  bool
 
 	OnStartedLeading func(chan struct{})
 	OnStoppedLeading func()
@@ -35,13 +36,14 @@ func (c *Controller) isLeader() bool {
 }
 
 func (c *Controller) leaderElection() {
-	elector := setupLeaderElection(&leaderElectionConfig{
+	config := &leaderElectionConfig{
 		Client:       c.config.KubeClient,
 		ElectionID:   "ovn-config",
 		PodName:      c.config.PodName,
 		PodNamespace: c.config.PodNamespace,
-	})
-	c.elector = elector
+	}
+
+	c.elector = setupLeaderElection(config)
 	for {
 		if c.isLeader() {
 			return
@@ -57,6 +59,7 @@ func setupLeaderElection(config *leaderElectionConfig) *leaderelection.LeaderEle
 		OnStartedLeading: func(ctx context.Context) {
 			klog.Infof("I am the new leader")
 			stopCh = make(chan struct{})
+			config.WasLeader = true
 
 			if config.OnStartedLeading != nil {
 				config.OnStartedLeading(stopCh)
@@ -73,6 +76,9 @@ func setupLeaderElection(config *leaderElectionConfig) *leaderelection.LeaderEle
 		},
 		OnNewLeader: func(identity string) {
 			klog.Infof("new leader elected: %v", identity)
+			if config.WasLeader && identity != config.PodName {
+				klog.Fatal("I am not leader anymore")
+			}
 			if config.OnNewLeader != nil {
 				config.OnNewLeader(identity)
 			}