libovsdb: fix potential duplicate addresses (#2763)

kubeovn · May 6, 2023 · bf1a3d7 · bf1a3d7
1 parent 5585d44
commit bf1a3d7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/ovs/ovn-nb-address_set.go b/pkg/ovs/ovn-nb-address_set.go
@@ -55,9 +55,6 @@ func (c *ovnClient) AddressSetUpdateAddress(asName string, addresses ...string)
 		return fmt.Errorf("get address set %s: %v", asName, err)
 	}
 
-	// update will failed when slice contains duplicate elements
-	addresses = util.UniqString(addresses)
-
 	// format CIDR to keep addresses the same in both nb and sb
 	for i, addr := range addresses {
 		if strings.ContainsRune(addr, '/') {
@@ -69,6 +66,10 @@ func (c *ovnClient) AddressSetUpdateAddress(asName string, addresses ...string)
 			addresses[i] = ipNet.String()
 		}
 	}
+
+	// update will failed when slice contains duplicate elements
+	addresses = util.UniqString(addresses)
+
 	// clear addresses when addresses is empty
 	as.Addresses = addresses