fix vip lsp not clean (#2848)

kubeovn · May 24, 2023 · d642f5b · d642f5b
1 parent a1cf2b3
commit d642f5b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/pkg/controller/vip.go b/pkg/controller/vip.go
@@ -187,6 +187,7 @@ func (c *Controller) handleAddVirtualIp(key string) error {
 	}
 	subnet, err := c.subnetsLister.Get(subnetName)
 	if err != nil {
+		klog.Errorf("failed to get subnet %s: %v", subnetName, err)
 		return err
 	}
 	portName := ovs.PodNameToPortName(vip.Name, vip.Namespace, subnet.Spec.Provider)
@@ -263,7 +264,13 @@ func (c *Controller) handleUpdateVirtualIp(key string) error {
 	if !vip.DeletionTimestamp.IsZero() {
 		// TODO:// clean vip in its parent port aap list
 		if vip.Spec.Type == util.SwitchLBRuleVip {
-			if err := c.ovnClient.DeleteLogicalSwitchPort(vip.Name); err != nil {
+			subnet, err := c.subnetsLister.Get(vip.Spec.Subnet)
+			if err != nil {
+				klog.Errorf("failed to get subnet %s: %v", vip.Spec.Subnet, err)
+				return err
+			}
+			portName := ovs.PodNameToPortName(vip.Name, vip.Namespace, subnet.Spec.Provider)
+			if err := c.ovnClient.DeleteLogicalSwitchPort(portName); err != nil {
 				err = fmt.Errorf("failed to delete lsp %s: %v", vip.Name, err)
 				klog.Error(err)
 				return err