Perf/libovsdb

[gugulee]

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features

Which issue(s) this PR fixes:

Fixes #1675

replace ovn-nbctl function call with libovsdb

[zhangzujian]

Why is this deleted?

[gugulee]

syncVmLiveMigrationPort 函数的目的是当虚拟机 liveMigration 完成后，把原虚拟机的 mac 和 ip 地址给新虚拟机。

这个函数要和 CreatePort（新版本函数名变为 CreateLogicalSwitchPort） 一起看才有意义，具体分为两种场景（假设虚拟机名字为 test-vm，对应迁移前和迁移后 vm pod 名字分别为：test-vm-1-xxx 和 test-vm-2-xxx）：

1. keep-vm-ip = true（意味着要保留 vm 的 ip） 时，test-vm-1-xxx 和 test-vm-2-xxx 的 logical_switch_port 的名字都为 test-vm.namespace.providerName，意味着当 test-vm-2-xxx 创建时，同时存在两个 pod 拥有同一个 lsp（包括 mac 和 ip），经过热迁移测试，发现不需要设置 lsp liveMigration=1，然后再 syncVmLiveMigrationPort 处理。

2. keep-vm-ip = false （意味着要不保留 vm 的 ip）时，test-vm-1-xxx 和 test-vm-2-xxx 分别拥有自己 ip 和 mac，和上述过程无关。

在新版 CreateLogicalSwitchPort 中，取消了设置 liveMigration=1，所以 syncVmLiveMigrationPort 函数也就不需要了。

[zhangzujian]

NAT outgoing for centralized subnets failed caused by missing logical router policy:

❯ kubectl ko nbctl lr-policy-list ovn-cluster
Routing Policies
     31000                            ip4.dst == 10.16.0.0/16           allow
     31000                           ip4.dst == 100.64.0.0/16           allow
     30000                              ip4.dst == 172.20.0.2         reroute                100.64.0.3
     30000                              ip4.dst == 172.20.0.3         reroute                100.64.0.2
# missing the following policy:
#    29000                              ip4.src == 10.16.0.0/16       reroute                100.64.0.3

kube-ovn-controller logs:

E1027 07:59:19.851029      10 node.go:983] get logical router policy: not found policy priority 29000 match ip4.src == 10.16.0.0/16 in logical router ovn-cluster
E1027 07:59:19.851044      10 node.go:993] failed to get policy route paras, not found policy priority 29000 match ip4.src == 10.16.0.0/16 in logical router ovn-cluster
E1027 07:59:19.851051      10 subnet.go:1615] check ecmp policy route exist for subnet ovn-default, error not found policy priority 29000 match ip4.src == 10.16.0.0/16 in logical router ovn-cluster

[zhangzujian]

kubeovnv1.ProtocolIPv4 should be replaced with protocol in the following lines:

https://github.com/kubeovn/kube-ovn/blob/perf/libovsdb/pkg/ovs/ovn-nb-acl.go#L43
https://github.com/kubeovn/kube-ovn/blob/perf/libovsdb/pkg/ovs/ovn-nb-acl.go#L83

[zhangzujian]

Suggested change

	if lb.Vips == nil {
	lb.Vips = make(map[string]string)
	}
	for vip, backends := range vips {
	lb.Vips[vip] = backends
	}
	updatedVips := make(map[string]string, len(lb.Vips)+len(vips))
	for vip, backends := range lb.Vips {
	updatedVips[vip] = backends
	}
	for vip, backends := range vips {
	updatedVips[vip] = backends
	}
	lb.Vips = updatedVips

Updating the filed directly will cause unexpected result.