Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix network break on kube-ovn-cni startup #2272

Merged
merged 1 commit into from Jan 29, 2023
Merged

fix network break on kube-ovn-cni startup #2272

merged 1 commit into from Jan 29, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jan 29, 2023 •
edited

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #2244

// 100.64.0.3/ffff0000
_ = ipAddr.IP.String()+"/"+ipAddr.Mask.String()
// 100.64.0.3/16
_ = ipAddr.IPNet.String()

Test command:

ping -DOq -i 0.001 172.18.0.2

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jan 29, 2023
@zhangzujian zhangzujian added this to In progress in 2023-1 via automation Jan 29, 2023
@zhangzujian zhangzujian marked this pull request as ready for review January 29, 2023 07:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 29, 2023
View reviewed changes
pkg/daemon/ovs_linux.go
@@ -514,12 +515,13 @@
ipAddMap[ipStr] = *ipAddr
}

for _, addr := range ipDelMap {
for ip, addr := range ipDelMap {
klog.Infof("delete ip address %s on %s", ip, link)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
pkg/daemon/ovs_linux.go
@@ -533,6 +535,7 @@
}
}

klog.Infof("add ip address %s to %s", ip, link)

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
@zhangzujian zhangzujian merged commit eddf18d into kubeovn:master Jan 29, 2023
2023-1 automation moved this from In progress to Done Jan 29, 2023
@zhangzujian zhangzujian deleted the fix-ovn0 branch January 29, 2023 08:24
zhangzujian added a commit that referenced this pull request Jan 29, 2023
@zhangzujian
fix network break on kube-ovn-cni startup (#2272)
a666303
zhangzujian added a commit that referenced this pull request Jan 29, 2023
@zhangzujian
fix network break on kube-ovn-cni startup (#2272)
ed53f30
zhangzujian added a commit that referenced this pull request Jan 29, 2023
@zhangzujian
fix network break on kube-ovn-cni startup (#2272)
63dc62a
zhangzujian added a commit that referenced this pull request Jan 29, 2023
@zhangzujian
fix network break on kube-ovn-cni startup (#2272)
ffd625f
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Feb 1, 2023
@zhangzujian
fix network break on kube-ovn-cni startup (kubeovn#2272)
ceb4bae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
bug Something isn't working need backport
Projects
No open projects
2023-1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When restart kube-ovn-cni ping from pod to node break
2 participants
@zhangzujian @oilbeater