Add kubectl ko log #2451
Merged
Add kubectl ko log #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changluyi
requested review from
zhangzujian and
oilbeater
and removed request for
zhangzujian
oilbeater
requested changes
Mar 9, 2023
| log(){ | ||
| component="$1" | ||
| sub_component="$2" | ||
| tail_lines=${3:-100} |
There was a problem hiding this comment.
We need a way to collect all lines.
oilbeater
requested changes
Mar 9, 2023
dist/images/kubectl-ko
Outdated
| @@ -26,8 +26,14 @@ showHelp(){ | |||
| echo " env-check check the environment configuration" | |||
| echo " tuning {install-fastpath|local-install-fastpath|remove-fastpath|install-stt|local-install-stt|remove-stt} {centos7|centos8}} [kernel-devel-version] deploy kernel optimisation components to the system" | |||
| echo " reload restart all kube-ovn components" | |||
| echo " log {kube-ovn|ovn|ovs|linux} {all|sub_component...} [tail_lines] | |||
There was a problem hiding this comment.
Need a short hand to collect logs for all components
oilbeater
approved these changes
Mar 13, 2023
changluyi
force-pushed
the
add_kubectl_ko_log
branch
from
89fce3c
to
d2cce41
Compare
changluyi
force-pushed
the
add_kubectl_ko_log
branch
from
61e608c
to
41e3714
Compare
changluyi
force-pushed
the
add_kubectl_ko_log
branch
from
54f0784
to
503bc94
Compare
zhangzujian
reviewed
Mar 15, 2023
| name: kubectl-ko-log | ||
| path: kubectl-ko-log.tar | ||
| name: k8s-conformance-e2e-ko-log | ||
| path: k8s-conformance-e2e-ko-log.tar |
There was a problem hiding this comment.
Suggested change
| path: k8s-conformance-e2e-ko-log.tar | |
| path: k8s-conformance-e2e-${{ matrix.mode }}-${{ matrix.ip-family }}-ko-log.tar |
changluyi
force-pushed
the
add_kubectl_ko_log
branch
2 times, most recently
from
ce0594d
to
75778b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #2400