Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underlay: get address/route before setting nm managed to no #2592

Merged
merged 1 commit into from Apr 3, 2023

Conversation

zhangzujian
Copy link
Member

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

In some scenarios, NetworkManager flushes the address/route after a device is set unmanaged. We should get the address/route before setting a device unmanaged by NetworkManager.

@zhangzujian zhangzujian added bug Something isn't working need backport labels Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

  • The commit message is missing. It should provide a clear and concise explanation of the changes made in the patch.
  • There are no potential bugs or format errors in the code.
  • There are no performance issues in the code.
  • One way to improve this code would be to add more comments to explain what each function does and how it works.

@zhangzujian zhangzujian merged commit 048e931 into kubeovn:master Apr 3, 2023
52 checks passed
@zhangzujian zhangzujian deleted the fix-nm branch April 3, 2023 05:41
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants