Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittest: fix length assertion #2597

Merged
merged 1 commit into from Apr 5, 2023
Merged

Conversation

zhangzujian
Copy link
Member

What type of this PR

Examples of user facing changes:

  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

@zhangzujian zhangzujian added test automation tests need backport labels Apr 4, 2023
@zhangzujian zhangzujian marked this pull request as ready for review April 4, 2023 01:39
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

  • The commit message should be more descriptive and informative.
  • In line 6, the assertion is comparing the length of args with itself instead of wants. It should be changed to Expect(len(args)).To(Equal(len(wants))).
  • In line 16, the assertion is comparing the length of args with itself instead of wants. It should be changed to Expect(args).To(HaveLen(len(wants))).
  • In line 31, the assertion is comparing the length of args with itself instead of wants. It should be changed to Expect(args).To(HaveLen(len(wants))).

@zhangzujian zhangzujian merged commit 4c7ddc6 into kubeovn:master Apr 5, 2023
52 checks passed
@zhangzujian zhangzujian deleted the fix-ut branch April 5, 2023 00:51
zhangzujian added a commit that referenced this pull request Apr 5, 2023
zhangzujian added a commit that referenced this pull request Apr 5, 2023
zhangzujian added a commit that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants