Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix multus installation #2604

Merged
merged 1 commit into from Apr 6, 2023
Merged

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Apr 5, 2023

What type of this PR

  • CI

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at fa7858e

Updated MULTUS_IMAGE in Makefile to use snapshot tag. This is to test kube-ovn with the latest multus-cni version.

馃 Generated by Copilot at fa7858e

MULTUS_IMAGE changed
To test kube-ovn with snapshot
MULTUS_YAML same

HOW

馃 Generated by Copilot at fa7858e

  • Update multus-cni image to use snapshot tag (link)

@zhangzujian zhangzujian marked this pull request as ready for review April 5, 2023 01:37
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

  • The commit message should provide more context about the changes made in this patch.
  • It is not clear why the MULTUS_IMAGE was changed from stable to snapshot. The commit message should explain this change or add a comment in the code explaining it.
  • The format of the Makefile seems consistent, but it would be good to double-check for any potential errors.
  • There are no performance issues that can be identified from this diff.
  • It might be helpful to add comments in the Makefile to explain what each variable is used for and how it affects the build process.

@oilbeater
Copy link
Collaborator

Any issue with the multus stable image?

@zhangzujian
Copy link
Member Author

We are using yaml from the master branch, which has changed the image tag from stable to snapshot.

This patch is supposed to fix the occasional multus installation failure:
https://github.com/kubeovn/kube-ovn/actions/runs/4624461863/jobs/8179433733

@zhangzujian zhangzujian merged commit 6bf15d4 into kubeovn:master Apr 6, 2023
53 checks passed
@zhangzujian zhangzujian deleted the fix-ci-multus branch April 6, 2023 02:56
zhangzujian added a commit that referenced this pull request Apr 6, 2023
zhangzujian added a commit that referenced this pull request Apr 6, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants