Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized tolerations code in vpc-nat-gw #2613

Merged
merged 1 commit into from Apr 7, 2023

Conversation

ShaPoHun
Copy link
Contributor

@ShaPoHun ShaPoHun commented Apr 6, 2023

What type of this PR

Examples of user facing changes:

  • Features
    Optimized tolerations code in vpc-nat-gw

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

  • The commit message is missing, please add a descriptive message explaining the changes made in the patch.
  • In the VpcNatSpec struct in types.go, the TolerationSeconds field should be of type int64 instead of integer.
  • In the genNatGwStatefulSet function in vpc_nat_gateway.go, the tolerations variable can be removed and replaced with gw.Spec.Tolerations.
  • In the VpcNatSpec struct in types.go, the VpcNatToleration struct can be removed since it is no longer used.
  • In the install.sh and crd.yaml files, the toleration.effect field should be of type corev1.TaintEffect instead of string.
  • In the install.sh and crd.yaml files, the toleration.operator field should be of type corev1.TolerationOperator instead of string.

@bobz965 bobz965 merged commit 42a8686 into kubeovn:master Apr 7, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants