Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netpol: fix packet drop casued by incorrect address set deletion #2677

Merged
merged 1 commit into from
Apr 20, 2023
Merged

netpol: fix packet drop casued by incorrect address set deletion #2677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 0 additions & 24 deletions pkg/controller/network_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,18 +238,6 @@ func (c *Controller) handleUpdateNp(key string) error {
}
}

ingressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "ingress")
if err != nil {
klog.Errorf("failed to list ingress address_set, %v", err)
return err
}
for _, ingressAsName := range ingressAsNames {
if err = c.ovnLegacyClient.DeleteAddressSet(ingressAsName); err != nil {
klog.Errorf("failed to delete np %s address set, %v", key, err)
return err
}
}

var ingressAclCmd []string
exist, err := c.ovnClient.PortGroupExists(pgName)
if err != nil {
Expand Down Expand Up @@ -381,18 +369,6 @@ func (c *Controller) handleUpdateNp(key string) error {
}
}

egressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "egress")
if err != nil {
klog.Errorf("failed to list egress address_set, %v", err)
return err
}
for _, egressAsName := range egressAsNames {
if err = c.ovnLegacyClient.DeleteAddressSet(egressAsName); err != nil {
klog.Errorf("failed to delete np %s address set, %v", key, err)
return err
}
}

var egressAclCmd []string
if exist, err = c.ovnClient.PortGroupExists(pgName); err != nil {
klog.Errorf("failed to query np %s port group, %v", key, err)
Expand Down