Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using full repo name to avoid short-name error in podman #2746

Merged
merged 1 commit into from May 4, 2023
Merged

Conversation

oilbeater
Copy link
Collaborator

@oilbeater oilbeater commented May 4, 2023

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2730

WHAT

🤖 Generated by Copilot at 98b5bec

Use official docker hub registry for kube-ovn images. Update charts/values.yaml to reflect the new registry address.

🤖 Generated by Copilot at 98b5bec

kubeovn address
changed to docker.io
pull images with ease

HOW

🤖 Generated by Copilot at 98b5bec

  • Change the global registry address to use the official docker hub repository (link). This allows users to pull the images without having to configure a local registry or mirror, and resolves issue release: prepare for 1.8 #1012.

@oilbeater oilbeater added bug Something isn't working need backport labels May 4, 2023
@oilbeater oilbeater requested a review from zhangzujian May 4, 2023 02:09
@oilbeater oilbeater added this to In progress in 2023-5 via automation May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

  • Priority 1: Update the registry address in charts/values.yaml and dist/images/install.sh to "docker.io/kubeovn" instead of "kubeovn". This is important because it ensures that the correct image is pulled from the correct registry, which can prevent issues with image versioning and compatibility.

  • Priority 2: Consider adding imagePullSecrets to the global section in charts/values.yaml. This can improve security by allowing for private registry authentication.

  • Priority 3: Review the use of hard-coded values such as VERSION and IMAGE_PULL_POLICY in dist/images/install.sh. These values may need to be updated or made configurable to ensure compatibility with different environments.

  • Priority 4: Consider adding validation checks to ensure that required variables are set before running dist/images/install.sh. This can help prevent errors and improve user experience.

  • Priority 5: Review the use of CNI_CONF_DIR and CNI_BIN_DIR in dist/images/install.sh. These values may need to be updated or made configurable to ensure compatibility with different Kubernetes distributions.

@oilbeater oilbeater merged commit 91400ec into master May 4, 2023
55 checks passed
2023-5 automation moved this from In progress to Done May 4, 2023
@oilbeater oilbeater deleted the fix/repo branch May 4, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

kube-ovn 的pod 一直显示 ImageInspectError,无法拉去镜像
2 participants