Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run kube-ovn e2e for underlay #2762

Merged
merged 1 commit into from May 6, 2023
Merged

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented May 6, 2023

What type of this PR

  • CI

Which issue(s) this PR fixes:

Some e2e cases, such as kubectl ko trace <pod>, should be run in both overlay and underlay.

WHAT

馃 Generated by Copilot at 869e2d7

Add overlay and underlay network mode testing to GitHub Actions workflow. Modify .github/workflows/build-x86-image.yaml to use a matrix variable and different commands for each mode.

馃 Generated by Copilot at 869e2d7

Kube-OVN modes
test overlay and underlay
autumn leaves falling

HOW

馃 Generated by Copilot at 869e2d7

  • Add a new matrix variable mode to test different network modes of Kube-OVN (link)
  • Install Kube-OVN with the corresponding mode variable in the kind cluster (link)
  • Set an environment variable E2E_NETWORK_MODE to select the appropriate end-to-end test cases based on the network mode (link)
  • Rename the log file and the artifact name and path to include the mode variable for the make kubectl-ko-log command and the upload-artifact action (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

  • 1. It is not clear what the "mode" parameter does in the matrix section. This should be documented or explained in a comment.
  • 2. The naming convention for the artifacts generated by the E2E tests is not consistent with the naming convention used in other parts of the workflow. This could cause confusion and should be standardized.
  • 3. The "sudo chown -R $(id -un). /.kube/" command in the "Setup Kind Cluster" step could potentially cause permission issues if the user running the workflow does not have ownership of the "/.kube/" directory. A more secure approach would be to use a Kubernetes configuration file that is mounted as a volume in the Kind cluster.
  • 4. The "make kind-install-${{ matrix.mode }}-${{ matrix.ip-family }}" command in the "Install Kube-OVN" step should be reviewed to ensure that it is correctly installing the desired version of Kube-OVN and that it is not introducing any regressions or breaking changes.
  • 5. The "make kube-ovn-conformance-e2e" command in the "Run E2E" step should be reviewed to ensure that it is correctly running the conformance tests and that it is not introducing any regressions or breaking changes. Additionally, it may be beneficial to add more detailed logging or error handling to this step to make it easier to diagnose failures.

@zhangzujian zhangzujian marked this pull request as ready for review May 6, 2023 05:17
@zhangzujian zhangzujian requested a review from oilbeater May 6, 2023 05:17
@zhangzujian zhangzujian merged commit 5585d44 into kubeovn:master May 6, 2023
61 checks passed
@zhangzujian zhangzujian deleted the fix-e2e branch May 6, 2023 05:27
zhangzujian added a commit that referenced this pull request May 6, 2023
zhangzujian added a commit that referenced this pull request May 6, 2023
zhangzujian added a commit that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants