Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos. #2814

Merged
merged 1 commit into from May 16, 2023
Merged

fix some typos. #2814

merged 1 commit into from May 16, 2023

Conversation

yojay11717
Copy link
Contributor

@yojay11717 yojay11717 commented May 16, 2023

What type of this PR

  • Bug fixes
    fix some typos.

Which issue(s) this PR fixes:

fix typos

WHAT

馃 Generated by Copilot at 3a9dd8d

Fix typos in QoSPolicyBandwidthLimitRules function and parameter names. Improve readability and consistency of bandwidth spelling in ./pkg/controller/qos_policy.go.

馃 Generated by Copilot at 3a9dd8d

Sing, O Muse, of the skillful coder who corrected
The errors in the names of structs and functions
That govern the limits of bandwidth, the precious resource
That flows like the river of Ocean around the earth.

HOW

馃 Generated by Copilot at 3a9dd8d

  • Fix typos in function and parameter names related to QoSPolicyBandwidthLimitRules (link, link, link, link, link, link)

@github-actions
Copy link
Contributor

  • Priority 1: There is a typo in the function name compareQoSPolicyBandwithLimitRules which should be corrected to compareQoSPolicyBandwidthLimitRules. This could cause confusion and potential errors when calling this function.
  • Priority 2: The function diffQoSPolicyBandwithLimitRules also has the same typo and should be corrected to diffQoSPolicyBandwidthLimitRules.
  • Priority 3: In the function patchQoSStatus, the parameter bandwithRules should be corrected to bandwidthRules to match the struct field name. This could cause errors when trying to access the struct field.
  • Priority 4: In the function handleUpdateQoSPolicy, there is a variable named bandwithRulesChanged that should be corrected to bandwidthRulesChanged to match the variable naming convention used throughout the codebase. This could cause confusion and potential errors when referencing this variable.
  • Priority 5: It may be beneficial to refactor the diffQoSPolicyBandwidthLimitRules function to improve its readability and reduce the amount of duplicated code. This could make it easier to maintain and modify in the future.

@zhangzujian
Copy link
Member

Thanks!

@zhangzujian zhangzujian merged commit fca6c9d into kubeovn:master May 16, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants