Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s to v1.27.2 #2861

Merged
merged 1 commit into from May 26, 2023
Merged

bump k8s to v1.27.2 #2861

merged 1 commit into from May 26, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented May 26, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at 5e38b1a

This pull request updates the dependencies and the default Kubernetes version for the kube-ovn project. It modifies the go.mod file to use the latest k8s.io modules and other libraries, and the yamls/kind.yaml.j2 file to use v1.27.2 as the default k8s_version variable for creating a kind cluster with kube-ovn.

馃 Generated by Copilot at 5e38b1a

To test kube-ovn with kind
We need the latest k8s version to find
So we update the yamls
And the k8s.io modules
And the forks that we have redefined

HOW

馃 Generated by Copilot at 5e38b1a

  • Update k8s.io modules to v0.27.2 to match the latest Kubernetes release (link, link, link, link)
  • Update jsonpatch library to v2.3.0 for applying JSON patches to Go structs (link)
  • Update replace directives for forked or modified modules that are used by kube-ovn for interacting with various components (link)
  • Update default Kubernetes version to v1.27.2 for creating a kind cluster with kube-ovn installed using the yamls/kind.yaml.j2 template and the hack/kind-cluster-build.sh script (link)

@zhangzujian zhangzujian added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 26, 2023
@github-actions
Copy link
Contributor

  • Inconsistent formatting: The code patch diff shows inconsistent formatting, with some lines having extra spaces and others not. This can make the code difficult to read and maintain. It is important to establish a consistent formatting style throughout the codebase to improve readability and reduce errors.

  • Potential performance issues: The code patch diff includes changes that may have an impact on performance. For example, adding new features or increasing the complexity of existing ones can slow down the system. It is important to carefully review these changes and ensure that they do not negatively affect performance.

  • Lack of comments/documentation: The code patch diff does not include sufficient comments or documentation to explain the purpose and functionality of the code. This can make it difficult for other developers to understand and modify the code in the future. It is important to add clear and concise comments and documentation to help others understand the code.

  • Security vulnerabilities: The code patch diff may introduce security vulnerabilities into the system. For example, if the code does not properly validate user input, it could be vulnerable to SQL injection attacks. It is important to review the code for potential security vulnerabilities and address them before deploying the code.

  • Code duplication: The code patch diff includes instances of code duplication, which can lead to maintenance issues and bugs. It is important to identify and eliminate code duplication to improve code quality and reduce the risk of errors.

@zhangzujian zhangzujian marked this pull request as ready for review May 26, 2023 03:11
@zhangzujian zhangzujian merged commit 32b8521 into kubeovn:master May 26, 2023
58 checks passed
@zhangzujian zhangzujian deleted the bump-k8s branch May 26, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants