Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

u2o support specify u2o ip on release-1.9 #2935

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

changluyi
Copy link
Collaborator

@changluyi changluyi commented Jun 13, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at ed91ab1

This pull request adds a new feature to allow users to specify a static IP address for the underlay to overlay interconnection in each subnet. It modifies the SubnetSpec schema and struct, the subnet.go and validator.go files, and the kube-ovn-crd.yaml and crd.yaml files to support the new u2oInterconnectionIP field and its validation and reconciliation logic. It also adds a check to prevent users from enabling both the logical gateway and the underlay to overlay interconnection features at the same time.

馃 Generated by Copilot at ed91ab1

Oh we are the coders of the kube-ovn
We make the subnets interconnect
We heave and we ho and we add a new field
u2oInterconnectionIP we set

HOW

馃 Generated by Copilot at ed91ab1

  • Add u2oInterconnectionIP field to SubnetSpec schema and struct to allow users to configure the underlay to overlay interconnection IP address for each subnet (link, link, link)
  • Enqueue subnet key for processing when u2oInterconnectionIP field changes in enqueueUpdateSubnet function in subnet.go (link)
  • Clear u2oInterconnectionIP field and set changed flag if u2oInterconnection field is not set in formatSubnet function in subnet.go (link)
  • Acquire or release static IP address for underlay to overlay interconnection logical router port based on u2oInterconnectionIP field in reconcileU2OInterconnectionIP function in subnet.go (link)
  • Validate that logicalGateway and u2oInterconnection fields are not both set to true, and that u2oInterconnectionIP field is within subnet CIDR range in ValidateSubnet function in validator.go (link)

@changluyi changluyi merged commit 110440f into release-1.9 Jun 13, 2023
42 checks passed
@changluyi changluyi deleted the u2o_spec_u2o_ip-release-1.9 branch June 13, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant