Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

u2o support specify u2o ip on release-1.11 #2937

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

changluyi
Copy link
Collaborator

@changluyi changluyi commented Jun 13, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

馃 Generated by Copilot at 7e2de89

This pull request adds a new feature to allow user-specified or dynamic IP addresses for the underlay to overlay interconnection in subnets. It modifies the SubnetSpec and SubnetStatus schemas, the subnet controller logic, and the subnet validation function. It also updates the kube-ovn-crd.yaml and crd.yaml files to reflect the schema changes.

馃 Generated by Copilot at 7e2de89

Oh we are the coders of the kube-ovn
We make the subnets interconnect
We heave and we ho and we validate
The u2oInterconnectionIP we set

HOW

馃 Generated by Copilot at 7e2de89

  • Add a new field U2OInterconnectionIP to the SubnetSpec struct to specify a static IP address for the underlay to overlay interconnection (link)
  • Add a new field u2oInterconnectionIP to the SubnetStatus schema in the kube-ovn-crd.yaml and crd.yaml files to store the IP address of the logical router port that connects the overlay subnet to the underlay network (link, link)
  • Validate the U2OInterconnectionIP field in the ValidateSubnet function and ensure that it is within the subnet CIDR and not conflicting with the logicalGateway field (link)
  • Enqueue the subnet key for processing when the U2OInterconnectionIP field changes in the enqueueUpdateSubnet function (link)
  • Clear the U2OInterconnectionIP field if the U2OInterconnection field is false and set the changed flag to true in the formatSubnet function (link)
  • Allocate or release the IP address for the underlay to overlay interconnection and update the subnet status accordingly in the reconcileU2OInterconnectionIP function, handling the cases where the U2OInterconnectionIP field is specified or changed by the user (link)

@changluyi changluyi merged commit effc111 into release-1.11 Jun 13, 2023
44 of 45 checks passed
@changluyi changluyi deleted the u2o_spec_u2o_ip-release-1.11 branch June 13, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant