Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: fix readOnly in volumes #3002

Merged
merged 2 commits into from Jul 3, 2023
Merged

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 1, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

W0701 15:23:44.162434   73735 warnings.go:70] unknown field "spec.template.spec.volumes[11].readOnly"

WHAT

🤖 Generated by Copilot at 97c7752

Remove readOnly attribute from ovn-config volume mount in ovn-central container. This enables dynamic OVN cluster reconfiguration.

🤖 Generated by Copilot at 97c7752

ovn-config writes
dynamic cluster reconfig
autumn leaves and joins

HOW

🤖 Generated by Copilot at 97c7752

  • Remove readOnly attribute from ovn-config volume mount in ovn-central container to enable dynamic OVN cluster reconfiguration (link)

@zhangzujian zhangzujian added bug Something isn't working chart Helm Chart labels Jul 1, 2023
@@ -197,7 +197,6 @@ spec:
- hostPath:
path: /var/run/containerd
name: cruntime
readOnly: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个readOnly 的位置错了,应该挪到 volumeMounts 中

@zhangzujian zhangzujian removed the bug Something isn't working label Jul 3, 2023
@zhangzujian zhangzujian merged commit 1236693 into kubeovn:master Jul 3, 2023
14 checks passed
@zhangzujian zhangzujian deleted the fix-chart branch July 3, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants