Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vpc already delete while delete policy route #3005

Merged
merged 1 commit into from Jul 5, 2023

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Jul 3, 2023

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2877

WHAT

馃 Generated by Copilot at 3a7e127

Improve policy route handling for custom VPC subnets. Prevent errors and unnecessary operations in subnet.go when deleting VPCs or subnets.

馃 Generated by Copilot at 3a7e127

Oh we are the coders of the policy routes
We work with the VPCs and the subnets too
We check for the errors and the deletions
And we pull and we push and we merge on the count of three

HOW

馃 Generated by Copilot at 3a7e127

  • Add a check for logical router existence before adding or deleting policy routes for U2O interconnection (link, link) in pkg/controller/subnet.go

@bobz965 bobz965 marked this pull request as ready for review July 3, 2023 03:29
@bobz965 bobz965 merged commit 269f460 into kubeovn:master Jul 5, 2023
56 of 59 checks passed
@bobz965 bobz965 deleted the fix-subnet-not-clean branch July 5, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subnet crd deleted but ovn nbctl show switch still exist, subnet created but deleted after a while
2 participants