Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: skip VIP gc if LB not found #3048

Merged
merged 1 commit into from Jul 19, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 18, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

In the first run, kube-ovn-controller may exit because the LB does not exist.

WHAT

馃 Generated by Copilot at d583ea9

Changed the error handling logic for GetLoadBalancer function in pkg/controller/gc.go to avoid unnecessary retries and log the missing load balancers.

馃 Generated by Copilot at d583ea9

GetLoadBalancer
No error if not found now
Autumn leaves falling

HOW

馃 Generated by Copilot at d583ea9

  • Change the behavior of GetLoadBalancer function call to return nil instead of error if load balancer is not found (link)

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jul 18, 2023
@zhangzujian zhangzujian merged commit 2ba3b8e into kubeovn:master Jul 19, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-gc-lb branch July 19, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants